Skip to content

Update DHT library dependency #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2023
Merged

Update DHT library dependency #37

merged 2 commits into from
Jun 16, 2023

Conversation

karlsoderby
Copy link
Contributor

Change the library for DHT sensor + add a wrapper class specifically for I2C connection (DHT20).

New library is the Grove Temperature and Humidity Sensor library which allows you to connect using a one-wire protocol (DHT11) and using I2C (DHT20).

@karlsoderby
Update DHT library
61321e0 
Change the library from DHT sensor + adds a wrapper class specifically for I2C connection (DHT20)
per1234
per1234 previously requested changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Compile Examples" CI workflow must also be updated to install the correct library dependency here:

Arduino_SensorKit/.github/workflows/compile-examples.yml

Line 57 in 61321e0

- name: DHT sensor library

@per1234 per1234 added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Jun 16, 2023
@github-actions
Copy link

Memory usage change @ 15469e3

Board flash % RAM for global variables %
arduino:avr:leonardo 🔺 +18 - +18 +0.06 - +0.06 🔺 +14 - +14 +0.55 - +0.55
arduino:avr:uno 🔺 +18 - +18 +0.06 - +0.06 🔺 +14 - +14 +0.68 - +0.68
arduino:megaavr:uno2018 🔺 +18 - +18 +0.04 - +0.04 🔺 +14 - +14 +0.23 - +0.23
Click for full report table
Board examples/Accelerometer
flash		 % examples/Accelerometer
RAM for global variables		 % examples/Combined_Demo
flash		 % examples/Combined_Demo
RAM for global variables		 % examples/Oled_Display
flash		 % examples/Oled_Display
RAM for global variables		 % examples/Plug_Sketch_Play
flash		 % examples/Plug_Sketch_Play
RAM for global variables		 % examples/Pressure_Sensor
flash		 % examples/Pressure_Sensor
RAM for global variables		 % examples/Temp_and_Humidity
flash		 % examples/Temp_and_Humidity
RAM for global variables		 %
arduino:avr:leonardo 18 0.06 14 0.55 18 0.06 14 0.55 18 0.06 14 0.55 18 0.06 14 0.55 18 0.06 14 0.55 18 0.06 14 0.55
arduino:avr:uno 18 0.06 14 0.68 18 0.06 14 0.68 18 0.06 14 0.68 18 0.06 14 0.68 18 0.06 14 0.68 18 0.06 14 0.68
arduino:megaavr:uno2018 18 0.04 14 0.23 18 0.04 14 0.23 18 0.04 14 0.23 18 0.04 14 0.23 18 0.04 14 0.23 18 0.04 14 0.23
Click for full report CSV 
Board,examples/Accelerometer<br>flash,%,examples/Accelerometer<br>RAM for global variables,%,examples/Combined_Demo<br>flash,%,examples/Combined_Demo<br>RAM for global variables,%,examples/Oled_Display<br>flash,%,examples/Oled_Display<br>RAM for global variables,%,examples/Plug_Sketch_Play<br>flash,%,examples/Plug_Sketch_Play<br>RAM for global variables,%,examples/Pressure_Sensor<br>flash,%,examples/Pressure_Sensor<br>RAM for global variables,%,examples/Temp_and_Humidity<br>flash,%,examples/Temp_and_Humidity<br>RAM for global variables,%
arduino:avr:leonardo,18,0.06,14,0.55,18,0.06,14,0.55,18,0.06,14,0.55,18,0.06,14,0.55,18,0.06,14,0.55,18,0.06,14,0.55
arduino:avr:uno,18,0.06,14,0.68,18,0.06,14,0.68,18,0.06,14,0.68,18,0.06,14,0.68,18,0.06,14,0.68,18,0.06,14,0.68
arduino:megaavr:uno2018,18,0.04,14,0.23,18,0.04,14,0.23,18,0.04,14,0.23,18,0.04,14,0.23,18,0.04,14,0.23,18,0.04,14,0.23

@karlsoderby
Copy link
Contributor Author

Thank you @per1234 , I updated the file so looks like it is working now!

@karlsoderby karlsoderby requested a review from per1234 June 16, 2023 08:03
@per1234 per1234 dismissed their stale review June 16, 2023 08:19

Requested changes have been made. Thanks!

@karlsoderby karlsoderby merged commit 6388a51 into main Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 Awaiting requested review from per1234

Assignees
No one assigned
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karlsoderby @per1234